Fix LT-22428: Add More than one line and Exactly one line filters#717
Fix LT-22428: Add More than one line and Exactly one line filters#717jtmaxwell3 wants to merge 7 commits intomainfrom
Conversation
jasonleenaylor
left a comment
There was a problem hiding this comment.
Is this filter limited to columns which could have multiple lines?
@jasonleenaylor made 1 comment.
Reviewable status: 0 of 6 files reviewed, all discussions resolved.
|
I want to run this idea by a couple of people before we merge it. I don't generally like the idea of adding filter options to columns where they do not apply. |
|
Would it work to put this logic in AppendSpaceForFirstWordInNewParagraph after the empty string check? Or are there bad consequences for that? |
|
Excellent, now add a param comment here describing the purpose and we're done. |
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor partially reviewed 6 files and resolved 1 discussion.
Reviewable status: 6 of 7 files reviewed, all discussions resolved.
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor partially reviewed 2 files and made 1 comment.
Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on jtmaxwell3).
This fixes https://jira.sil.org/browse/LT-22428. We changed allomorph columns and allomorph property columns to include lexeme forms so that the properties would line up with the allomorphs. But this means that users can no longer see just the entries with non-lexeme allomorphs by filtering on Non-blanks. We added filters for More than one line and Exactly one line to handle this use case.
This change is